On 12/15/2016 09:50 PM, Tran, Quinn wrote: > Qlogic was asked to support other Target Stack (SCST) using the same > qla2xxx.ko upstream driver. I had mentioned this during the last 2015 > LSF get together. Hopefully, that gives a better context. The > understanding that came away was “Qlogic do what is needed to provide > this support without creating any dead code”. > > [ ... ] > > The patches look like its copying a lot of fields without doing a whole > lot, instead the patches are translating the request from tcm_qla2xxx to > qla2xxx. Hello Quinn, Are you perhaps referring to the 2015 LSF/MM session I had proposed ([LSF/MM TOPIC] Unifying the LIO and SCST target drivers - https://marc.info/?l=linux-scsi&m=142122995413575)? The approach taken in patch 08/22 of this series is not what I had in mind. More in general, as you maybe know shim (translation) layers are not welcome in the Linux kernel. Simplifying the LIO core is still on my to do list. A possible starting point is the patch series I posted one year ago ([PATCH 00/20] SCSI target patches for kernel v4.4 - https://www.spinics.net/lists/target-devel/msg10788.html). That kind of simplification helps with reducing the maintenance burden for target drivers that support the two in-kernel SCSI target stacks without violating any of the established rules for kernel driver development. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html