On Thu, Dec 15, 2016 at 08:50:39PM +0000, Tran, Quinn wrote: > Christoph, > > Qlogic was asked to support other Target Stack (SC ST) using the same qla2xxx.ko upstream driver. I had mentioned this during the last 2015 LSF get together. Hopefully, that gives a better context. The understanding that came away was “Qlogic do what is needed to provide this support without creating any dead code”. Right. And what you're doing here is to create tons of pointless and dead code. If you can support something else without clearly making the in-kernel version worse it's all fine. This patch on the other hand is complete crap and totally unacceptable in this form. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html