Doug Maxey wrote: >> What is the struct cleanup though? typedef->just struct usage? >> > > mainly, yes. Ok. I am fine if you want to do that. For iscsi_tcp and friends we fixed this, but nobody ever said anything about the typedef usage during the initial qla4xxx postings so I thought we had been overly careful/picky. For scsi I never saw anyone complain about the single file issue either. However for the netdev review it looks like the qlogic net driver got that comment and the typedef one. What about the mixed case variable names and other junk? Some people get a way with them and others don't. For scsi is the policy to not be that picky or did some drivers sneak in? > do we need to track the sparse types (__le*) for device > data? > Yeah I think so. I do not think you were CCd on the coding style todo. Qlogic and I sometimes drop you form CCs and forget to add you back on later. Sorry about that. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
