> -----Original Message----- > From: Martin K. Petersen [mailto:martin.petersen@xxxxxxxxxx] > Sent: Monday, November 14, 2016 5:44 PM > To: Don Brace > Cc: jejb@xxxxxxxxxxxxxxxxxx; John Hall; Kevin Barnett; Mahesh > Rajashekhara; Bader Ali-saleh; hch@xxxxxxxxxxxxx; Scott Teel; Viswas G; > Justin Lindley; Scott Benesh; elliott@xxxxxxx; POSWALD@xxxxxxxx; linux- > scsi@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] hpsa: correct logical resets > > EXTERNAL EMAIL > > > >>>>> "Don" == Don Brace <don.brace@xxxxxxxxxxxxx> writes: > > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c > index 0b6eb5a..a296537 100644 > --- a/drivers/scsi/hpsa.c > +++ b/drivers/scsi/hpsa.c > @@ -300,6 +300,10 @@ static bool hpsa_cmd_dev_match(struct ctlr_info *h, > struct CommandList *c, > struct hpsa_scsi_dev_t *dev, > unsigned char *scsi3addr); > > +static int wait_for_device_to_become_ready(struct ctlr_info *h, > + unsigned char lunaddr[], > + int reply_queue); > + > static inline struct ctlr_info *sdev_to_hba(struct scsi_device *sdev) > { > unsigned long *priv = shost_priv(sdev->host); > > Wouldn't it be nicer to put this with the rest of the function > prototypes at the beginning of the file? > > -- > Martin K. Petersen Oracle Linux Engineering Ok, I can move it up above static int hpsa_wait_for_board_state(struct pci_dev *pdev, void __iomem *vaddr, int wait_for_ready); Thanks, Don Brace ESC - Smart Storage Microsemi Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
