On 11/10/2016 03:48 PM, Christoph Hellwig wrote: > On Thu, Nov 10, 2016 at 07:48:20AM +0100, Hannes Reinecke wrote: >> What I find quite irritating is that we still have to call >> irq_set_affinity_hint(irq, NULL) when freeing up interrupts. >> Can't we roll that into the call to free_irq() ? > > If you do call it that's irritation, because you should not call > irq_set_affinity_hint ever if you are using PCI_IRQ_AFFINITY, and > the above branch doesn't call it. > Ah. Sorry to have misread that. >> And you _do_ have to setup a cpumap within the driver :-) > > For the non-mq case, yes - but only to keep the functionality > as-is. We shouldn't add anything like this to a new driver. > >> Anyway, remainder looks pretty close to what I've written up. >> Feel free to add my 'Reviewed-by:' to it. > > I'm mostly looking for someone who has the hardware to actually > test it, though. > Ah. Right. Will give it a spin tomorrow. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
