On 11/09/2016 10:39 PM, Christoph Hellwig wrote: > On Tue, Nov 08, 2016 at 04:02:54PM +0100, Hannes Reinecke wrote: >>> I've looked at the them but haven't started work, so feel free to go >>> ahead. The MSI-X handling in mpt3sas is pretty nasty, so be careful. >>> >>> I've also started playing with lpfc, something I'll need to send to >>> you and James for testing and feedback soon. >>> >> Bah. Another duplicate then. >> Let's see who is faster :-) > > Here are the lpfc patches - note that it's in a branch that merges > the recent irq affinity changes from the tip tree into the scsi tree > first, as we need updates from both of them: > > http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/lpfc-msix > What I find quite irritating is that we still have to call irq_set_affinity_hint(irq, NULL) when freeing up interrupts. Can't we roll that into the call to free_irq() ? Thing is, we're not _calling_ irq_set_affinity_hint() when setting up the interrupt, so it'll be one of the things which will be easily forgotten. And you _do_ have to setup a cpumap within the driver :-) Anyway, remainder looks pretty close to what I've written up. Feel free to add my 'Reviewed-by:' to it. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
