Dear Guennadi,
Return the active request for retry to the upper layer in case of
"reselect without disconnect" instead of just losing it.
Oh, thank you for the patch. Now the scan is finished even if several
"reselect: w/o disconnected cmds <02-0> with active srb" happened during
the operation. A funny artifact though can be seen at the picture (this is
a ~800KB map of Japan http://kapitza.ras.ru/~leva/Japan.jpg ). It looks
like during each reselect a chunk of data is lost (or maybe transferred
twice?) and the data stream gets an offset. My understanding is that the
scan data are 8bits per color component which gives 24bits/pixel.
Any idea why it happens and how to fix it?
On Wed, 7 Jun 2006 at 11:28pm, Guennadi Liakhovetski wrote:
Now, below is a patch... That's about all I can say about it:-) The
reselect routine didn't seem right to me, specifically, it checks for "no
active request-block or active request-block is not disconnected" and then
sends an abort to the device, but if there was indeed an active srb, it
gets lost, AFAICS. FWIW, tmscsim does the same... The patch below tries to
complete the command before dropping it on the floor... Any reviews
appreciated.
And there's one more page_address there in dc395x...
Warning, Lev - this patch may explode your scanner, or upload your bank
account info to p2p servers, or send your gpg keys to microsoft, or...
You've been warned:-) You might want to wait for some comments to the
patch...
Thanks for the warning :-)
-L.
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
