On Monday, October 24, 2016 3:34:27 PM CEST Binoy Jayan wrote: > Hi Arnd > > On 20 October 2016 at 14:36, Arnd Bergmann <arnd@xxxxxxxx> wrote: > > On Thursday, October 20, 2016 2:24:01 PM CEST Binoy Jayan wrote: > >> Semaphores are going away in the future, so replace the semaphore > >> sync_request_sem with the a mutex lock. timeout_msecs is not used > >> for the lock sync_request_sem, so remove the timed locking too. > >> > >> Signed-off-by: Binoy Jayan <binoy.jayan@xxxxxxxxxx> > > > > The patch looks correct to me, but I think if you remove the support > > for handling timeouts, you should update the prototype of > > pqi_submit_raid_request_synchronous to no longer pass the timeout > > argument in the first place. > > But we still need "timeout_msecs" in a call to > pqi_submit_raid_request_synchronous_with_io_request() > > drivers/scsi/smartpqi/smartpqi_init.c +3484 Why? If it's always zero, we can remove that too. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
