On 20 October 2016 at 14:40, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Thursday, October 20, 2016 2:24:01 PM CEST Binoy Jayan wrote: >> - sema_init(&ctrl_info->sync_request_sem, >> - PQI_RESERVED_IO_SLOTS_SYNCHRONOUS_REQUESTS); >> + mutex_init(&ctrl_info->sync_request_mutex); >> > > Looking at this again, I see that PQI_RESERVED_IO_SLOTS_SYNCHRONOUS_REQUESTS > is '3', so this is in fact a counting semaphore rather than a mutex, > and the conversion is changing the behavior. > > The patch can't go in unless you either show that it should be > a normal mutex rather than a counting semaphore, or you find a way > to keep the behavior the same. This still holds true, will try changing this accordingly. -Binoy -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
