On Tue, May 30, 2006 at 11:11:59AM -0600, Ju, Seokmann wrote: > > Why would you want to do that? A subfunction of a __devinit function > > should also be __devinit (unless it's alsoi used by something which > > isn't __devinit, of course) > For similar reason as you pointed out, I thought it would be good to remove (unless it is required) the tag so that it can be called by any functions in the driver if needed be. If it turns out you want to call it from elsewhere in the driver, you should remove the __devinit tag at that time. > I don't have enough knowledge on the topic, unfortunately. Is it hardly required to have the tag on all sub-functions called in the function? > If so, there are couple of other sub-functions need to have the tag. It's not required, but it is a good idea. Marking the function as __devinit allows the function to be discarded when we know it can't be called again (an infrequent case these days, to be sure, but one the embedded people are grateful for). - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
