> Why would you want to do that? A subfunction of a __devinit function > should also be __devinit (unless it's alsoi used by something which > isn't __devinit, of course) For similar reason as you pointed out, I thought it would be good to remove (unless it is required) the tag so that it can be called by any functions in the driver if needed be. I don't have enough knowledge on the topic, unfortunately. Is it hardly required to have the tag on all sub-functions called in the function? If so, there are couple of other sub-functions need to have the tag. Thank you, Seokmann > -----Original Message----- > From: Matthew Wilcox [mailto:matthew@xxxxxx] > Sent: Tuesday, May 30, 2006 1:03 PM > To: Ju, Seokmann > Cc: Randy.Dunlap; __smail D?nmez; scsi; akpm; jejb; Kolli, Neela > Subject: Re: [PATCH] megaraid_mbox: fix section mismatch warnings > > On Tue, May 30, 2006 at 07:37:18AM -0600, Ju, Seokmann wrote: > > > */ > > > -static int __init > > > +static int __devinit > > > megaraid_init_mbox(adapter_t *adapter) > > > Thank you for pointing out a bug. > > However, in my opinion, I would rather to simply remove > '__init' from the function. > > The function is just a sub function called by > megaraid_probe_one which has '__devinit' tag. > > Please let me know if this is acceptable. > > I will submit a patch with proper change. > > Why would you want to do that? A subfunction of a __devinit function > should also be __devinit (unless it's alsoi used by something which > isn't __devinit, of course) > - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
