"Randy.Dunlap" <rdunlap@xxxxxxxxxxxx> wrote:
>
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
>
> Fix section mismatch warnings:
> WARNING: drivers/scsi/qla1280.o - Section mismatch: reference to
> .init.data: from .text between 'qla1280_get_token' (at offset 0x2a16)
> and 'qla1280_probe_one'
> WARNING: drivers/scsi/qla1280.o - Section mismatch: reference to
> .init.data: from .text between 'qla1280_get_token' (at offset 0x2a3c)
> and 'qla1280_probe_one'
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
> ---
> drivers/scsi/qla1280.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-2617-rc5.orig/drivers/scsi/qla1280.c
> +++ linux-2617-rc5/drivers/scsi/qla1280.c
> @@ -456,7 +456,7 @@ static void qla1280_remove_one(struct pc
> * QLogic Driver Support Function Prototypes.
> */
> static void qla1280_done(struct scsi_qla_host *);
> -static int qla1280_get_token(char *);
> +static int qla1280_get_token(char *) __init;
We don't normally put section tags on declarations. So I dropped this hunk
- unless you see a need for it?
> static int qla1280_setup(char *s) __init;
OK, for consistency. But let's not be consistent with inconsistent stuff ;)
> /*
> @@ -4234,7 +4234,7 @@ qla1280_setup(char *s)
> }
>
>
> -static int
> +static int __init
> qla1280_get_token(char *str)
> {
> char *sep;
And that's not really a bugfix - it's just a save-a-bit-of-memory fix.
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
