"Randy.Dunlap" <rdunlap@xxxxxxxxxxxx> wrote:
>
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
>
> Fix section warning:
> WARNING: drivers/scsi/megaraid/megaraid_mbox.o - Section mismatch: reference to .init.text: from .text between 'megaraid_probe_one' (at offset 0x171e) and 'megaraid_queue_command'
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
> ---
> drivers/scsi/megaraid/megaraid_mbox.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2617-rc5.orig/drivers/scsi/megaraid/megaraid_mbox.c
> +++ linux-2617-rc5/drivers/scsi/megaraid/megaraid_mbox.c
> @@ -714,7 +714,7 @@ megaraid_io_detach(adapter_t *adapter)
> * . Allocate memory required for all the commands
> * . Use internal library of FW routines, build up complete soft state
> */
> -static int __init
> +static int __devinit
> megaraid_init_mbox(adapter_t *adapter)
> {
> struct pci_dev *pdev;
>
>
<trying to get the old brain sorted out here>
This one's a bugfix, isn't it? In the CONFIG_HOTPLUG kernel the __devinit
megaraid_probe_one() resides in .text and calls the __init
megaraid_init_mbox(), which isn't there any more. So if this driver is
statically linked into vmlinux and the kernel is hotplug-capable and if
someone hotplugs one of these devices we go blam.
You agree with that analysis?
If so, I'll toss this onto the 2.6.17 pile, thanks.
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
