On Mon, May 22, 2006 at 07:54:35PM -0500, James Bottomley wrote: > Actually, we've got another cockup here with drivers: some have set this > to 8 or 16 and others to 7 or 15. If we apply this without auditing > them, for those who set it to 7 or 15, the last target will end up > inaccessible. So as scsi maintainer, what's your preference for the 'right way' to fix this? Clearly a whole-scale driver audit is needed, so my preference is to rename the variable (how about id_limit?) and then do a sweep checking that everybody's using it correctly. Then we need to do a similar check for max_lun and max_channel. As far as conventions go, I think we should use 8 and 16; it's just so much more natural to write 'for (id = 0; id < id_limit; id++)'. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
