On Sat, 22 Apr 2006 00:30:34 +0200 (CEST) Guennadi Liakhovetski wrote: > On Fri, 21 Apr 2006, Randy.Dunlap wrote: > > > My current (ugly, debug) patch is at > > http://www.xenotime.net/linux/patches/aha152x-sg-pio.patch > > A couple of quick notes: > > 1. You have to disable local interrupts before (scsi_)kmap_atomic(_sg)() > and restore them after (scsi_)kunmap_atomic(_sg)() (didn't check the > context of your patch, so, maybe it is already the case, if not, please, > fix) It wasn't there but I saw other recent patches like that, so I was aware of it. Fixed now. > 2. You have to initialise your sg_len variable before calling > scsi_kmap_atomic_sg() Oops, fixing that one. and added the flush_kernel_dcache_page() call too. Thanks. --- ~Randy - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
