On Thu, 13 Apr 2006, Randy.Dunlap wrote: > On Sun, 2 Apr 2006 21:57:43 +0200 (CEST) Guennadi Liakhovetski wrote: > > > Hello all, > > > > This time I really mean it:-) > > Hi Guennadi, > James pointed me at this patch since I have aha152x also having > problems with using page_address() while trying to do PIO. > I see a NULL pointer during a data-out phase. I'll attempt > to use the kmap_atomic() support that you have added in the > aha152x driver. Would be great to put these functions under some more extensive testing! I also want to use them in tmscsim, but there I do not have a test case for PIO:-( > > + * scsi_kmap_atomic_sg - find and atomically map an sg-elemnt > > s/elemnt/element/ Thanks. > > +/** > > + * scsi_kunmap_atomic_sg - atomically unmap a virtual address, previously > > + * mapped with scsi_kmap_atomic_sg > > First line of function kernel-doc must be just one line long. Sorry. :( > You can add more descriptive text after the parameter(s) plus one > blank line if you want to do it that way. Sure, thanks. I'll do the necessary modifications in the next version of the patch. I'd wait a bit more to see if there are some more comments. Regards Guennadi --- Guennadi Liakhovetski - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
