Al Viro wrote:
On Wed, Feb 22, 2006 at 01:34:42AM +0100, Stefan Richter wrote:
Al's patch is certainly better since it adds checks to the actual
affected code region, i.e. mode_sense handling in the SCSI layers.
James, would you integrate this patch?
However sbp2 will keep some sort of skip_ms_page_8 blacklisting anyway
because of different issues with other bridges.
Sure, but for this bridge it's not needed - with that fix we get the
right data out of bridge response. Note
+sda: missing header in MODE_SENSE response
and
+SCSI device sda: drive cache: write back
in that diff. The former is exactly what we get when we detect that
sort of breakage (bare page 6 without header) and the latter is where
we manage to get the cache type.
Yes, you are definitly right about it.
--
Stefan Richter
-=====-=-==- --=- =-==-
http://arcgraph.de/sr/
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
