Bernhard Kaindl wrote:
I tested the current ieee1394 cumulative patch in -mm1 from
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc4/2.6.16-rc4-mm1/broken-out/git-ieee1394.patch
with my Initio and it still triggered the CONFIG_DEBUG_SLAB detector.
What I don't understand is why mode page 8 is still accessed in your
log: http://bugzilla.kernel.org/attachment.cgi?id=7432&action=view
(Log lines "command: Mode Sense (10): 5a 00 08 00 00 00 00 00 d9 00",
"SCSI transfer size = 17d9" --- yeah, into a 512 Bytes big buffer, "sda:
got wrong page".) Could you please add a printk() or SBP2_INFO() within
the if() clause of sbp2scsi_slave_alloc() to make sure it is entered?
Could you also add the line
SBP2_INFO("skip_ms_page_8 = %d", sdev->skip_ms_page_8);
before the return in sbp2scsi_slave_configure()? Not that your kernel
looses the flag somewhere along the way...
This patch from Al Viro fixed the slab message for me:
Re: TYPE_RBC cache fixes (sbp2.c affected)
2006-02-21 13:51
http://sourceforge.net/mailarchive/message.php?msg_id=14879016
Bernhard
--
PS: My bug report for this was: http://bugzilla.kernel.org/show_bug.cgi?id=6114
Al's patch is certainly better since it adds checks to the actual
affected code region, i.e. mode_sense handling in the SCSI layers.
James, would you integrate this patch?
However sbp2 will keep some sort of skip_ms_page_8 blacklisting anyway
because of different issues with other bridges.
--
Stefan Richter
-=====-=-==- --=- =-==-
http://arcgraph.de/sr/
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
