Re: [PATCH] fc_transport: stop creating duplicate rport entries.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Is it necessary - e.g. register w/o role, then update it ? No, if
the lldd wants to plogi then wait for prli to occur before registering
the rport - that's fine.

However, I've found it easier, especially for non-FCP entities, to
register the rport as soon as it was detected (works for anything, non-FCP
included), then when prli completes update the role (works only w/ FCP).

mptfc is fine to register once with the roles already known.

-- james


Michael Reed wrote:

James Smart wrote:
Good Catch!

-- james s

Andrew Vasquez wrote:
Current fc_transport consumers initially register rports
with an UNKNOWN role-state and follow-up with a call to
fc_remote_port_rolechg().

So, is the above sequence necessary?  Why not just register
the rport with appropriate role and state?  This is what
LSI fusion driver (mptfc) does.  "roles" has target and
initiator set.  (Is fusion broken?)

(Not saying the fix shouldn't be there.)

Mike

<...snip...>


-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux