On Wed, Jan 04, 2006 at 09:13:36AM +0100, Rolf Eike Beer wrote:
> Al Viro wrote:
> >On Wed, Jan 04, 2006 at 08:51:57AM +0100, Rolf Eike Beer wrote:
> >> Mike Christie wrote:
> >> >+ while (end_that_request_first(req, 0, req->nr_sectors))
> >> >+ ;
> >>
> >> This should be something like
> >>
> >> while (...)
> >> {}
> >>
> >> so it is absolutely clear that the empty body is intentional.
> >
> >Please, do not inflict that ugliness on everyone. FWIW, it's less
> >idiomatic than normal use of ; and personally I'd parse it as "somebody
> >had fscked up using editor", not as "wow, they _really_ meant it to be
> >an empty body".
>
> Using only ; on a single line looks like some code left over from removing
> code...
It's a common idiom and above code is copy and pasted from a perfectly
fine indented function. So could you please stop this silly discussion
now?
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
