Al Viro wrote:
>On Wed, Jan 04, 2006 at 08:51:57AM +0100, Rolf Eike Beer wrote:
>> Mike Christie wrote:
>> >+ while (end_that_request_first(req, 0, req->nr_sectors))
>> >+ ;
>>
>> This should be something like
>>
>> while (...)
>> {}
>>
>> so it is absolutely clear that the empty body is intentional.
>
>Please, do not inflict that ugliness on everyone. FWIW, it's less
>idiomatic than normal use of ; and personally I'd parse it as "somebody
>had fscked up using editor", not as "wow, they _really_ meant it to be
>an empty body".
Using only ; on a single line looks like some code left over from removing
code... Ok, so let's agree to disagree. Since coding style says the opening
brace should be on the same line as the while, would it be better to put
everthing in one line to make clear what's going on?
Eike
Attachment:
pgpr4UfSIHHK6.pgp
Description: PGP signature
