Re: [PATCH 2.4 2/2] cpqfc: Reduce stack usage of 2 functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 02, 2006 at 01:05:37PM +0100, Rolf Eike Beer wrote:
> There are 2 function that do a lookup to the queue and buffer the result. 
> They only care about the first few bytes (to be exactly: 38*sizeof(u32)), 
> but they always pass a buffer of 2kB, which is located on the stack.
> 
> This patch reduces this buffer to the really needed size and changes it's 
> type to the correct target type. The rest of the queue is still looked up 
> but the result is ignored (as it would anyway).
> 
> There are also some small cleanups for the other arguments of 
> CpqTsGetSFQEntry(), which is the lookup function.

Hi Rolf,

Is there an evidence that the gratuitous stack usage is causing problems with
an 8kB stack? 

In other ways, this looks more like an optimization than a serious bugfix? 
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux