James Bottomley wrote: > On Wed, 2005-12-07 at 16:16 -0600, Michael Reed wrote: >> FWIW, the situation I'm reporting isn't done after timeout, it's >> the scsi error handler calling the LLDD abort routine, which actually >> aborts the command and completes it. The eh_action is cleared before >> the abort, violating what appears to be the accepted protocol of having >> the LLDD complete aborted commands. >> >> Am I missing something in your comment? (It wouldn't surprise me!) > > The timeout race still exists, though. Both fixes would solve both > problems. It would just be easier to follow if the logic of the error > handler done follows that of the normal done function (i.e. don't do > anything after the command times out). "Ah ha", he said. Further examination of the code clarifies what you were suggesting. I'll see what I can work up. Thanks, Mike - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
