James Bottomley wrote: > On Wed, 2005-12-07 at 15:56 -0600, Michael Reed wrote: >> During my testing of fc transport attributes for the mpt fusion >> driver, I came upon this OOPS. (Actually, I've come upon it >> too many times. :( ) >> >> Attached is a patch which addresses the issue. Please give it a look. > > Isn't a better patch simply to copy the eh_action and check it for null > before completing it? That will close the done after timeout race. FWIW, the situation I'm reporting isn't done after timeout, it's the scsi error handler calling the LLDD abort routine, which actually aborts the command and completes it. The eh_action is cleared before the abort, violating what appears to be the accepted protocol of having the LLDD complete aborted commands. Am I missing something in your comment? (It wouldn't surprise me!) Thanks, Mike - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
