> Once you start touching these could we please get rid of the > bitfield for > hardware registers abuse? These should be proper 8/16/32 bit > members and > then using bitmask as in all proper written drivers. Agreed. A coding style that I've preached as well. But with existing code, it takes a while to adapt. > That beeing said there's tons of sparse warnings in lpfc, in > large parts > due to things like this. Would be nice if someone at emulex > could get the > driver sparse and endianess clean. We'll add this to our todo list. Given the volume of the change, don't look for this to be resolved too quickly. -- james s - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
