> #ifdef __BIG_ENDIAN_BITFIELD > uint8_t nameType:4; /* FC Word 0, bit 28:31 */ > - uint8_t IEEEextMsn:4; /* FC Word 0, bit 24:27, bit 8:11 of IEEE ext */ > + uint8_t IEEEextMsn:4; /* FC Word 0, bit 24:27, bit > + 8:11 of IEEE ext */ > #else /* __LITTLE_ENDIAN_BITFIELD */ > - uint8_t IEEEextMsn:4; /* FC Word 0, bit 24:27, bit 8:11 of IEEE ext */ > + uint8_t IEEEextMsn:4; /* FC Word 0, bit 24:27, bit > + 8:11 of IEEE ext */ > uint8_t nameType:4; /* FC Word 0, bit 28:31 */ > #endif Once you start touching these could we please get rid of the bitfield for hardware registers abuse? These should be proper 8/16/32 bit members and then using bitmask as in all proper written drivers. That beeing said there's tons of sparse warnings in lpfc, in large parts due to things like this. Would be nice if someone at emulex could get the driver sparse and endianess clean. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
