On Tue, Nov 15, 2005 at 01:11:47PM +0100, Kars de Jong wrote:
> Indeed, and there's issues with the iomap interface to solve as well.
>
> Also, I don't know the proper chip register settings for all supported
> boards yet (hence the printk() with register settings).
>
> With all m68k 53c700 implementations currently supported there should be
> no byteswapping done in io{read,write}32(), but that doesn't hold for
> each bus.
>
> So until we can specify in some way how the io{read,write}{16,32}()
> function should behave on a certain memory region, I see no way to
> integrate this cleanly. For now I am inclined to do something like this
> in 53c700.h:
>
> #ifdef CONFIG_M68K
> iowrite32be(bS_to_io(value), hostdata->base + reg);
> #else
> iowrite32(bS_to_io(value), hostdata->base + reg);
> #endif
The 53c700 already has a rather awkward mechanism to deal with different
bus byte orders, I'd suggest you use that now and switch the driver to
use ioread*be later, without introducing arch-specific config symbols.
Anyway, could you folks please submit what you have now? The 53c7xx hasn't
worked ever in 2.6.x, and we're gonna remove it for 2.6.16. It would be
nice to keep the m68k glue drivers switched over to use 53c700 even if there's
still some odd hacks required to actually make it work - we'll surely sort
them out once the basics are in.
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
