Jeff Garzik wrote: > Brian King wrote: > >>Remove some of the dependence on the host_set struct >>in preparation for supporting SAS HBAs. Adds a struct device >>pointer to the ata_port struct. >> >>This patch depends on the qc_transport patch: >> >>http://marc.theaimsgroup.com/?l=linux-ide&m=112845939215286&w=2 >> >>Signed-off-by: Brian King <brking@xxxxxxxxxx> >>--- >> >> linux-2.6-bjking1/drivers/scsi/libata-core.c | 13 +++++++------ >> linux-2.6-bjking1/include/linux/libata.h | 1 + >> 2 files changed, 8 insertions(+), 6 deletions(-) >> >>diff -puN include/linux/libata.h~libata_host_set_dev include/linux/libata.h >>--- linux-2.6/include/linux/libata.h~libata_host_set_dev 2005-10-24 15:04:22.000000000 -0500 >>+++ linux-2.6-bjking1/include/linux/libata.h 2005-10-24 15:04:22.000000000 -0500 >>@@ -315,6 +315,7 @@ struct ata_port { >> >> struct ata_host_stats stats; >> struct ata_host_set *host_set; >>+ struct device *dev; >> >> struct work_struct packet_task; >> > > > Patch seems basically OK. But taking this patch to its conclusion means > deleting 'dev' from struct ata_host_set too... I wonder what breakage > will result from that? It breaks ata_pci_host_stop: void ata_pci_host_stop (struct ata_host_set *host_set) { struct pci_dev *pdev = to_pci_dev(host_set->dev); pci_iounmap(pdev, host_set->mmio_base); } I could poke into the first port here to get the 'dev', but I didn't particularly like that. I also thought about changing the prototype for host_set to pass in the 'dev' pointer, but wasn't sure that would work for the non PCI case. Or, we just live with the duplication... -- Brian King eServer Storage I/O IBM Linux Technology Center - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
