On Mon, 17 Oct 2005, Christoph Hellwig wrote: > > Use physical addresses at the interface level, letting drivers remap > > them as appropriate. > > > - esp->eregs = (struct ESP_regs *) (system_base + IOASIC_SCSI); > > + esp->eregs = (void *)CKSEG1ADDR(dec_kn_slot_base + > > + IOASIC_SCSI); > > Both the old and new code look very odd. This looks like iomaped-ish > memory and should be using some iomap variant. The patch is probably > okay for now, but I'd prefer if this used the proper APIs. It's a step in the transition to modern I/O bus APIs for TURBOchannel systems. It's certainly not going to stay there any longer than necessary as this driver is meant to support Alphas and VAXen eventually. Maciej - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
