On Sat, Oct 15, 2005 at 02:26:31AM +0100, Ralf Baechle wrote: > FYI. This is part of a larger MIPS patch which I'd like to submit > to akpm as a single patch. Please don't do that _ever_. (dito for the other bits sent out) scsi patches should be submitted to linux-scsi as individual patcvhes. > Use physical addresses at the interface level, letting drivers remap > them as appropriate. > - esp->eregs = (struct ESP_regs *) (system_base + IOASIC_SCSI); > + esp->eregs = (void *)CKSEG1ADDR(dec_kn_slot_base + > + IOASIC_SCSI); Both the old and new code look very odd. This looks like iomaped-ish memory and should be using some iomap variant. The patch is probably okay for now, but I'd prefer if this used the proper APIs. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
