Patrick Mansfield wrote on Wednesday, October 12, 2005 1:00 PM > > > It turns out that qla2x00 driver unnecessarily activated > > > generic blk tag queue without actually use any of the tag > > > maintained by the block layer. I suggest we turn that off > > > until there is a real consumer of the tag queuing in the > > > qla driver. Please apply. > > > > > > Signed-off-by: Ken Chen <kenneth.w.chen@xxxxxxxxx> > > > > ACK. > > And then also remove scsi_populate_tag_msg() calls also in qla2xxx, > as that becomes dead code? Yeah, that would indeed be a very good thing to do. It reminds me a while back, I was investigating cache miss profile and we consistently see cache misses on tag[2] variable defined in qla2x00_start_scsi (used by scsi_populate_tag_msg). Removing it would be a very good thing for driver performance. Should I generate the patch? - Ken - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
