Re: [patch] fix unnecessary activation of blk tag queue for qla2x00

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 07, 2005 at 10:03:56AM -0700, Andrew Vasquez wrote:
> On Fri, 07 Oct 2005, Chen, Kenneth W wrote:
> 
> > Regarding to discussion on LKML:
> > http://marc.theaimsgroup.com/?t=112865351000001&r=1&w=2
> 
> Ok, I had expected something like this to show on ls after the
> discussion on lk.
> 
> > It turns out that qla2x00 driver unnecessarily activated generic
> > blk tag queue without actually use any of the tag maintained by
> > the block layer.  I suggest we turn that off until there is a
> > real consumer of the tag queuing in the qla driver. Please apply.
> > 
> > Signed-off-by: Ken Chen <kenneth.w.chen@xxxxxxxxx>
> > 
> 
> ACK.

And then also remove scsi_populate_tag_msg() calls also in qla2xxx, as
that becomes dead code?

And then we can't pass down the task attribute. That does not matter now
as long as there are still no blk barriers for scsi (with can_queue or
queue_depth > 0, and some other scsi_host value set).

-- Patrick Mansfield
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux