Mike Christie wrote:
Kai Makisara wrote:
init_command() is _not_ called. I added a printk to it and it did not
print anything. If you look at scsi_prep_fn(), init_command() is
called only if req->rq_disk is set. scsi_execute_async() does not set it.
oh yeah, sorry. I meant to add that back but would have had to add
another argument to the scsi_execute* functions since I could not figure
out how to go from scsi_device or request_queue to disk.
Setting command parameters through the separate init_command()
function seems like a horrible idea. You have to do hacks to pass the
information.
This is how sd works :(
But I guess if every ULD has to add a done() then scsi-ml could set it
if we just add a complete_command on the scsi_driver.
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
