Re: [PATCH 4/5] convert st to use scsi_execte_async

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mike Christie wrote:
Kai Makisara wrote:


I think I may have found the problem: scsi_execute_async does not use the parameter retries (the same applies to scsi_execute btw). This leads to retrying the reads at filemark and this is not correct. I added the hack below to scsi_execute_async and after this the simple tests succeed.


ah ok. I think when we prep the command we need to copy the retries from the command. So in st.c st_init_command callout we need to copy that value (we are just copying the timeout today).

oh I guess there is not retries count on the request like there is for timeout :)

But it looks like retried is always 0. I guess st's init_command could just do

SCpnt->allowed = 0;
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux