On Fri, 9 Sep 2005, James Bottomley wrote: > On Thu, 2005-09-08 at 16:49 -0400, Alan Stern wrote: > > This hasn't been tested very thoroughly, so please look through it > > carefully. > > Actually, just one problem and one cosmetic fix: > > 1) We need to dequeue for the loop and kill case (it seems easiest > simply to dequeue in the scsi_kill_request() routine) > 2) There's no real need to drop the queue lock. __scsi_done() is lock > agnostic, so since there's no requirement, let's just leave it in to > avoid any locking issues. Have you applied this to any publicly-accessible tree yet? I looked at the git browsers on parisc-linux.org and kernel.org, but the patch doesn't seem to be there yet. For that matter, what about the other patches you agreed to take (as543 - as546)? They aren't in the git repositories either. It would be good if all these things could be ready in time for the next -mm release. Alan Stern - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html