On Thu, Aug 18, 2005 at 02:50:19PM -0500, Dmitry Torokhov wrote:
> On 8/18/05, Greg KH <greg@xxxxxxxxx> wrote:
> > @@ -500,9 +519,13 @@ int class_device_add(struct class_device
> > }
> >
> > class_device_add_attrs(class_dev);
> > - if (class_dev->dev)
> > + if (class_dev->dev) {
> > + class_name = make_class_name(class_dev);
> > sysfs_create_link(&class_dev->kobj,
> > &class_dev->dev->kobj, "device");
> > + sysfs_create_link(&class_dev->dev->kobj, &class_dev->kobj,
> > + class_name);
> > + }
> >
>
> I wonder if we need to grab a reference to class_dev->dev here:
>
> dev = device_get(class_dev->dev);
> if (dev) {
> ....
> }
>
> Otherwise, if device gets unregistered/deleted before class device is
> deleted we'll get into trouble when removing the link since
> class_dev->dev will be garbage.
>
> .. But grabbing that reference will cause pains in SCSI system which,
> when I looked, removed class devices from device's release function.
No the sysfs_create_link() call increments the kobject reference on the
target of the symlink. See sysfs_add_link() for details. So this
should be just fine, right?
thanks,
greg k-h
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
