On Mon, Aug 15, 2005 at 05:41:17PM -0500, James Bottomley wrote: > On Sun, 2005-08-14 at 16:02 +0100, Matthew Wilcox wrote: > > /sys/class/tty/ttyS0/device -> ../../../devices/parisc/0/0:0/pci0000:00/0000:00:04.0 > > /sys/class/tty/ttyS1/device -> ../../../devices/parisc/0/0:0/pci0000:00/0000:00:04.0 > > /sys/class/tty/ttyS2/device -> ../../../devices/parisc/0/0:0/pci0000:00/0000:00:04.0 > > /sys/class/tty/ttyS3/device -> ../../../devices/parisc/0/0:0/pci0000:00/0000:00:05.0 > > /sys/class/tty/ttyS4/device -> ../../../devices/parisc/0/0:0/pci0000:00/0000:00:05.0 > > Actually, isn't the fix to all of this to combine Greg and James' > patches? Yes it is. > The Greg one fails in SCSI because we don't have unique class device > names (by convention we use the same name as the device bus_id) and > James' one fails for ttys because the class name isn't unique. However, > if the link were derived from something like > > <class name>:<class device name> > > Then is would be unique in both cases. I agree. > Unless anyone can think of any more failing cases? I'll try this out and see if anything breaks :) thanks, greg k-h - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
