On Sat, Jul 09, 2005 at 01:41:20PM -0500, James Bottomley wrote: > On Sat, 2005-07-09 at 13:49 -0400, Ben Collins wrote: > > It's not the lock change that is breaking things, it's the RBC changes. > > SBP2 simply doesn't work (incorrect information read from the driver, > > which I assume is bad translation of the scsi commands caused by the > > changes). > > The RBC changes were tested out by Al Viro and seemed to work well. > > The intent of the changes looks good (bringing TYPE_RBC into SCSI where > it belongs and updating sd.c to handle RBC differences), so probably > what needs to happen is that we fix whatever's broken in the current > TYPE_RBC framework. It just may be that SBP2 doesn't work well with the changes. There's a little bit of workarounds and massaging to get things to work on most SBP2 drives. This may be one more thing that needs some massaging. -- Debian - http://www.debian.org/ Linux 1394 - http://www.linux1394.org/ Subversion - http://subversion.tigris.org/ SwissDisk - http://www.swissdisk.com/ - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html