On Mon, Jun 20 2005, Christoph Hellwig wrote: > On Mon, Jun 20, 2005 at 12:41:14PM +0200, Jens Axboe wrote: > > > That would be? > > > > Stacking drivers or file systems. > > Doesn't make sense, a stacking driver must not deal with locking down > user memory at all, and for filesystem there's better helpers in That's a very generic statement to make, there could be valid uses of that. But the point of the matter is that I don't think we should just remove bio_map_user() and intentionally break an exported API to save a few bytes. We are not talking a lot of code, it's just a wrapper. > fs/direct-io.c That's true, I'll give you that. > > > > While I do agree with the change, I know of external users of > > > > bio_map_user(). > > > > > > Who's that? > > > > ocfs2, iirc. > > ocfs2 doesn't use bio_map_user It did at some point in time, I don't track the tree so apparently they stopped doing so at some point. -- Jens Axboe - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
