Re: [PATCH 1/1] ipr: Fix for adapter shutdown issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 15, 2005 at 11:44:59AM -0500, James Bottomley wrote:

> 
> Well, I still think you're operating unsafely ... some people let these
> batteries run out, you know ...
> 
> To fix this, add a
> 
> blk_queue_ordered(sdev->request_queue, QUEUE_ORDERED_NONE);
> 
> to the slave configure routine for each of the devices that doesn't
> synchronize the cache.  That should correct the SCSI layer assumptions.

I don't get it.

First in scsi_alloc_queue, the flush/sync code is only used if we don't
have ordered tags, and if the adapter driver explicitly allows it
(shost->order_flush).

Plus we clear order_flush in scsi_host_alloc if can_queue > 1.

So ipr will never get those sync cache commands, correct?

And we default to QUEUE_ORDERED_NONE (0) if ordered_tag and ordered_flush
are not set.

But I can't find any where that we set ordered_tag at all, am I missing
something??? Let alone in ipr.

-- Patrick Mansfield
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux