James Bottomley wrote: > On Wed, 2005-06-15 at 10:15 -0500, brking@xxxxxxxxxx wrote: > >>Haren found this in some recent kexec testing. Without this fix, the >>ipr adapter's write cache never gets flushed. I'd like to see this >>pushed into 2.6.12 if possible. > > > Just out of curiosity, what are you doing with the SYNCHRONIZE_CACHE > that comes down from sd on shutdown? For scsi disks attached to an ipr adapter, the SYNCHRONIZE_CACHE command gets sent to the disk and works just like when attached to any other HBA. The ipr disk array devices, however, do not support the SYNC_CACHE command, nor do they support the caching mode page, so SYNC_CACHE never gets sent. So, the shutdown hook is needed to flush the adapter's battery backed write cache for all attached disk arrays on system shutdown. -- Brian King eServer Storage I/O IBM Linux Technology Center - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html