On Thu, 2005-06-02 at 17:15 -0500, Nathan Lynch wrote: > This patch works for me (tm); is it correct? > > Signed-off-by: Nathan Lynch <ntl@xxxxxxxxx> Yes, it is. Apparently every other caller except IPR uses the standard scsi_scan_target() interface, which does have this extra get_device(), I can't think how it got left off the __scsi_add_device path ... well, except that it wouldn't show up during testing. I suppose someone should look at converting ipr to scsi_scan_target() and we can eliminate this API (the only difference is that scsi_add_device returns the actual device, but ipr never uses this...) In the meantime, I'll put this in rc fixes. Thanks, James - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html