On Fri, 29 Apr 2005, Greg KH wrote: > On Sat, Apr 30, 2005 at 08:52:31AM +0300, Kai Makisara wrote: > > On Fri, 29 Apr 2005, Greg KH wrote: > > ... > > > Switch it in both capable() calls in the patch? Kai, is this acceptable > > > to you also? > > > > > Yes. Using CAP_SYS_ADMIN here was wrong. > > Ok, care to send a new patch that I can use for the next -stable kernel > release? > Sent in a different message. This patch does not restrict usage of SCSI_IOCTL_START_UNIT and SCSI_IOCTL_STOP_UNIT. For tapes, those mean load and unload commands. The drive status changes resulting from these commands seem to be caught by st otherwise. I will do a patch for -12rc later today or tomorrow. It may add changing some st status bits if these commands succeed but that is not -stable material. Thanks for the review for all participants. -- Kai - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
