On Tue, 2005-04-05 at 08:21 +0100, Christoph Hellwig wrote: > What I really don't like is that you still need ifdefs and wrappers to > support BE and LE wired chips in the same driver. Shouldn't you set the > BE or LE flag at iomap() time and always use the same accessors? No, if you look how it works. On parisc, it can be either BE or LE depending on the chip wiring. There would be a case for selecting BE or LE by #define, but there's no case I know today where we have a driver that would always be BE. James - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html