On Tue, Mar 18, 2025 at 12:38:15PM +0000, Peng Fan wrote: ... > > Also the commit message doesn't tell anything about the existing DTS > > files. > > Do we have this device described in any in the kernel? Do we have any > > googled examples? Why I'm asking because often the issue is the > > incorrect setting of the polarity, which needs to be carefully checked, > > esp. for the voltage regulators case. > > Under arch/arm/boot/dts/samsung/, a few dtsi files have the property > with results from output of > `grep "s5m8767" ./arch/arm/boot/dts/samsung/ -rn | grep gpios` Side note: `git grep -n s5m8767` is a better command. You can just look for the exact GPIOs, usually not so bit amount of them, or do it recursively with `git grep -n 'gpios' -- $(git grep -lw s5m8767 -- Documentation/devicetree/bindings)` > Exynos5250-spring.dts uses GPIO_ACTIVE_LOW. > Others use GPIO_ACTIVE_HIGH. So, one of this needs to be fixed. > The current changing to using GPIO descriptors should be ok per > my understanding. > > Not able to find any public datasheet for this pmic (: -- With Best Regards, Andy Shevchenko
