Hi Krzysztof, On Thu, 13 Mar 2025 at 13:19, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On 12/03/2025 15:59, Anand Moon wrote: > >> > >>> + mutex_lock(&_T->lock), mutex_unlock(&_T->lock)) > >>> + > >>> /* > >>> * TMU treats temperature as a mapped temperature code. > >>> * The temperature is converted differently depending on the calibration type. > >>> @@ -256,7 +260,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) > >>> unsigned int status; > >>> int ret = 0; > >>> > >>> - mutex_lock(&data->lock); > >>> + guard(mutex)(&data->lock); > >> > >> Which you do not use... Please don't use cleanup.h if you do not know > >> it. It leads to bugs. > >> > > Ok, I will drop this include of cleanup.h. > > So the guards as well... > Ok I will drop this patch thanks. > Best regards, > Krzysztof Thanks -Anand