Hi All, On Mon, 10 Mar 2025 at 20:05, Anand Moon <linux.amoon@xxxxxxxxx> wrote: > > Refactor the initialization of the clk_sec clock to be inside the > SOC_ARCH_EXYNOS5420_TRIMINFO case. It ensures that the clk_sec clock > is only initialized for the specified SOC and not for other SOCs, > thereby simplifying the code. The clk_sec clock is used by the TMU > for GPU on the Exynos 542x platform. > > Removed redundant IS_ERR() checks for the clk_sec clock since error > handling is already managed internally by clk_unprepare() functions. > > Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx> On Exynos4412 Odroid U3 uses the clocks name clock-names = "tmu_apbif"; On Exynos5422 Odroid XU4 uses the clocks name clock-names = "tmu_apbif", "tmu_triminfo_apbif"; So Exynos 5433 and Exynos7 SoC use the clocks name clock-names = "tmu_apbif", "tmu_sclk"; As per my understanding, there could be a common case for GPU clock in TMU driver which could simplify the code, any thoughts -----------------------8<------------------------------------- switch (data->soc) { case SOC_ARCH_EXYNOS5420_TRIMINFO: case SOC_ARCH_EXYNOS5433: case SOC_ARCH_EXYNOS7: Thanks -Anand