On Sat, 01 Mar 2025 01:08:15 +0530, Kaustabh Chakraborty wrote: > Add unique identifiers for exynos7870 clocks for every bank. It adds all > clocks of CMU_MIF, CMU_DISPAUD, CMU_G3D, CMU_ISP, CMU_MFCMSCL, and > CMU_PERI. Document the devicetree bindings as well. > > Signed-off-by: Kaustabh Chakraborty <kauschluss@xxxxxxxxxxx> > --- > .../bindings/clock/samsung,exynos7870-cmu.yaml | 227 +++++++++++++++ > include/dt-bindings/clock/samsung,exynos7870-cmu.h | 324 +++++++++++++++++++++ > 2 files changed, 551 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/samsung,exynos7870-cmu.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename $id: http://devicetree.org/schemas/clock/samsung,exynos7870-clock.yaml file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/samsung,exynos7870-cmu.yaml Documentation/devicetree/bindings/clock/samsung,exynos7870-cmu.example.dts:18:18: fatal error: dt-bindings/clock/exynos7870.h: No such file or directory 18 | #include <dt-bindings/clock/exynos7870.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/clock/samsung,exynos7870-cmu.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1511: dt_binding_check] Error 2 make: *** [Makefile:251: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250301-exynos7870-pmu-clocks-v4-1-0f3e73b10db7@xxxxxxxxxxx The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
