On 27/02/2025 06:56, Vinod Koul wrote: > Hi Krzysztof, > > On 15-02-25, 10:41, Krzysztof Kozlowski wrote: > > Can you revise the title to "phy: exynos5-usbdrd: dont depend on type-c" > or something relevenant which describes the change rather than the > Fix something! Sure, it won't change the fact that we are fixing broken USB dependency. > >> Older Exynos designs, like Exynos5422, do not have USB Type-C and the >> USB DRD PHY does not really depend on Type-C for these devices at all. >> Incorrectly added dependency on CONFIG_TYPEC caused this driver to be >> missing for exynos_defconfig and as result Exynos5422-based boards like >> Hardkernel Odroid HC1 failed to probe USB. >> >> Drop incorrect dependency and rely on module to be reachable by the >> compiler. > > Changelog lgtm > >> >> Reported-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> >> Closes: https://krzk.eu/#/builders/21/builds/6139 >> Reported-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> >> Closes: https://lore.kernel.org/all/3c0b77e6-357d-453e-8b63-4757c3231bde@xxxxxxxxxxx/ >> Fixes: 09dc674295a3 ("phy: exynos5-usbdrd: subscribe to orientation notifier if required") >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> >> --- >> >> Patch for issue in linux-next >> --- >> drivers/phy/samsung/Kconfig | 1 - >> drivers/phy/samsung/phy-exynos5-usbdrd.c | 2 +- >> 2 files changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/phy/samsung/Kconfig b/drivers/phy/samsung/Kconfig >> index 7fba571c0e2b..e2330b0894d6 100644 >> --- a/drivers/phy/samsung/Kconfig >> +++ b/drivers/phy/samsung/Kconfig >> @@ -81,7 +81,6 @@ config PHY_EXYNOS5_USBDRD >> tristate "Exynos5 SoC series USB DRD PHY driver" >> depends on (ARCH_EXYNOS && OF) || COMPILE_TEST >> depends on HAS_IOMEM >> - depends on TYPEC || (TYPEC=n && COMPILE_TEST) > > So how would this dependency be sorted..? That was a v1 and new versions are on the lists with simpler approach. > Best regards, Krzysztof
