On Wed, Feb 19, 2025 at 12:19:51AM +0530, Kaustabh Chakraborty wrote:
> S2MPU05 is a PMIC by manufactured by Samsung, particularly used in
> Exynos7870 based devices. Add driver support for controlling its 21 LDO
> and 5 BUCK regulators.
>
> Signed-off-by: Kaustabh Chakraborty <kauschluss@xxxxxxxxxxx>
> Acked-by: Mark Brown <broonie@xxxxxxxxxx>
> ---
> drivers/regulator/Kconfig | 4 +-
> drivers/regulator/s2mps11.c | 92 ++++++++++++++++++++++++++++++++++++++++++++-
> 2 files changed, 93 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index 39297f7d8177193e51c99bc2b360c6d9936e62fe..e47ef257696e2ff3745affa1a403a29f086a2833 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -1330,10 +1330,10 @@ config REGULATOR_S2MPA01
> via I2C bus. S2MPA01 has 10 Bucks and 26 LDO outputs.
>
> config REGULATOR_S2MPS11
> - tristate "Samsung S2MPS11/13/14/15/S2MPU02 voltage regulator"
> + tristate "Samsung S2MPS11/13/14/15/S2MPU02/05 voltage regulator"
> depends on MFD_SEC_CORE || COMPILE_TEST
> help
> - This driver supports a Samsung S2MPS11/13/14/15/S2MPU02 voltage
> + This driver supports a Samsung S2MPS11/13/14/15/S2MPU02/05 voltage
> output regulator via I2C bus. The chip is comprised of high efficient
> Buck converters including Dual-Phase Buck converter, Buck-Boost
> converter, various LDOs.
> diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c
> index 7dcf92af8f15e63fb634d978fba41df0ca09fd65..b54f9bba21a9c9af7d72449529e74e1445f7d455 100644
> --- a/drivers/regulator/s2mps11.c
> +++ b/drivers/regulator/s2mps11.c
> @@ -21,6 +21,7 @@
> #include <linux/mfd/samsung/s2mps14.h>
> #include <linux/mfd/samsung/s2mps15.h>
> #include <linux/mfd/samsung/s2mpu02.h>
> +#include <linux/mfd/samsung/s2mpu05.h>
>
> /* The highest number of possible regulators for supported devices. */
> #define S2MPS_REGULATOR_MAX S2MPS13_REGULATOR_MAX
> @@ -254,6 +255,9 @@ static int s2mps11_regulator_enable(struct regulator_dev *rdev)
> else
> val = rdev->desc->enable_mask;
> break;
> + case S2MPU05:
> + val = rdev->desc->enable_mask;
> + break;
> default:
> return -EINVAL;
> }
> @@ -1118,6 +1122,86 @@ static const struct regulator_desc s2mpu02_regulators[] = {
> regulator_desc_s2mpu02_buck7(7),
> };
>
> +#define regulator_desc_s2mpu05_ldo_reg(num, min, step, reg) { \
> + .name = "LDO"#num, \
lowercase
> + .id = S2MPU05_LDO##num, \
> + .ops = &s2mpu02_ldo_ops, \
> + .type = REGULATOR_VOLTAGE, \
> + .owner = THIS_MODULE, \
> + .min_uV = min, \
> + .uV_step = step, \
> + .n_voltages = S2MPU05_LDO_N_VOLTAGES, \
> + .vsel_reg = reg, \
> + .vsel_mask = S2MPU05_LDO_VSEL_MASK, \
> + .enable_reg = reg, \
> + .enable_mask = S2MPU05_ENABLE_MASK, \
> + .enable_time = S2MPU05_ENABLE_TIME_LDO \
> +}
> +
> +#define regulator_desc_s2mpu05_ldo(num, reg, min, step) \
> + regulator_desc_s2mpu05_ldo_reg(num, min, step, S2MPU05_REG_L##num##reg)
> +
> +#define regulator_desc_s2mpu05_ldo1(num, reg) \
> + regulator_desc_s2mpu05_ldo(num, reg, S2MPU05_LDO_MIN1, S2MPU05_LDO_STEP1)
> +
> +#define regulator_desc_s2mpu05_ldo2(num, reg) \
> + regulator_desc_s2mpu05_ldo(num, reg, S2MPU05_LDO_MIN1, S2MPU05_LDO_STEP2)
> +
> +#define regulator_desc_s2mpu05_ldo3(num, reg) \
> + regulator_desc_s2mpu05_ldo(num, reg, S2MPU05_LDO_MIN2, S2MPU05_LDO_STEP2)
> +
> +#define regulator_desc_s2mpu05_ldo4(num, reg) \
> + regulator_desc_s2mpu05_ldo(num, reg, S2MPU05_LDO_MIN3, S2MPU05_LDO_STEP2)
> +
> +#define regulator_desc_s2mpu05_buck(num, which) { \
> + .name = "BUCK"#num, \
Same here.
Best regards,
Krzysztof
